Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Максим Орлов <orlovmg(at)gmail(dot)com>
Cc: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, Maxim Orlov <m(dot)orlov(at)postgrespro(dot)ru>, lubennikovaav(at)gmail(dot)com
Subject: Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.
Date: 2022-01-12 06:47:34
Message-ID: CAOBaU_Zo2NytWVn9kMS2_uY0ExOg0KofG1=jA4ZjmKfcrbCn_g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Fri, Dec 24, 2021 at 2:06 AM Максим Орлов <orlovmg(at)gmail(dot)com> wrote:
>
> Thanks for your review! Fixed all these remaining things from patch v6.
> PFA v7 patch.

The cfbot reports that you have mixed declarations and code
(https://cirrus-ci.com/task/6407449413419008):

[17:21:26.926] pg_amcheck.c: In function ‘main’:
[17:21:26.926] pg_amcheck.c:634:4: error: ISO C90 forbids mixed
declarations and code [-Werror=declaration-after-statement]
[17:21:26.926] 634 | int vmaj = 0,
[17:21:26.926] | ^~~

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2022-01-12 06:48:55 Re: do only critical work during single-user vacuum?
Previous Message Tom Lane 2022-01-12 06:37:05 Re: cfbot wrangling (was Re: Add checkpoint and redo LSN to LogCheckpointEnd log message)