| From: | Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> |
|---|---|
| To: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
| Cc: | Максим Орлов <orlovmg(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, David Steele <david(at)pgmasters(dot)net>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, Maxim Orlov <m(dot)orlov(at)postgrespro(dot)ru>, lubennikovaav(at)gmail(dot)com |
| Subject: | Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index. |
| Date: | 2022-01-12 07:58:24 |
| Message-ID: | CALT9ZEEjHUWAMoBsXzJ91gYu4uJA+Ywms-+ZO1EwCPw2GbH-zw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> The cfbot reports that you have mixed declarations and code
> (https://cirrus-ci.com/task/6407449413419008):
>
> [17:21:26.926] pg_amcheck.c: In function ‘main’:
> [17:21:26.926] pg_amcheck.c:634:4: error: ISO C90 forbids mixed
> declarations and code [-Werror=declaration-after-statement]
> [17:21:26.926] 634 | int vmaj = 0,
> [17:21:26.926] | ^~~
>
Corrected this, thanks!
Also added more comments on this part of the code.
PFA v8 of a patch
--
Best regards,
Pavel Borisov
Postgres Professional: http://postgrespro.com <http://www.postgrespro.com>
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Add-option-for-amcheck-and-pg_amcheck-to-check-un.patch | application/octet-stream | 42.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-01-12 08:27:26 | Re: POC: Cleaning up orphaned files using undo logs |
| Previous Message | Masahiko Sawada | 2022-01-12 07:44:37 | Re: Add index scan progress to pg_stat_progress_vacuum |