From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | [pgAdmin4][Patch]: RM #3277 Runtime startup error handling is broken on Windows. |
Date: | 2018-05-10 13:00:25 |
Message-ID: | CANxoLDcBHYpsK3+ijxh-xXKnPbe39iMZpk4QyMHE5VYahqAw=Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers,
Please find the attached patch to fix RM #3277 Runtime startup error
handling is broken on Windows.
This issue is regression of RM #3177 "Sporadically crashes on Windows when
exit". Where below code of pgAdmin4.cpp creates the problem:
*QObject::connect(server, SIGNAL(finished()), server, SLOT(deleteLater()));*
In case when PythonPath is not provided then application server not started
and server thread finished there execution, due to the above line of code
*Destructor* of Server class has been called and we are accessing the
function *server->getError().length() *at line no 251 of pgAdmin4.cpp,
which cause the application crash.
I have removed that line and tested RM #3177 and RM# 3277, both are working
fine.
Please review and test it.
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Attachment | Content-Type | Size |
---|---|---|
RM_3277.patch | application/octet-stream | 431 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2018-05-10 14:08:00 | Re: [pgAdmin4][Patch]: RM #3277 Runtime startup error handling is broken on Windows. |
Previous Message | Xuri Gong | 2018-05-10 11:35:46 | GSoC Introduction - Implement geospatial data viewer in pgAdmin4 for PostGIS |