Re: refactoring basebackup.c

From: Jeevan Ladhe <jeevanladhe(dot)os(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Abhijit Menon-Sen <ams(at)toroid(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
Subject: Re: refactoring basebackup.c
Date: 2022-02-11 15:05:25
Message-ID: CANm22CgPb1qZRHxqr6jzP2Xt_c3=6TiCBv_AB5G9eqBP90XDgw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks Robert for the bravity :-)

Regards,
Jeevan Ladhe

On Fri, 11 Feb 2022, 20:31 Robert Haas, <robertmhaas(at)gmail(dot)com> wrote:

> On Fri, Feb 11, 2022 at 7:20 AM Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>
> wrote:
> > > Sure, please find the rebased patch attached.
> >
> > Thanks, I have validated v2 patch on top of rebased patch.
>
> I'm still feeling brave, so I committed this too after fixing a few
> things. In the process I noticed that we don't have support for LZ4
> compression of streamed WAL (cf. CreateWalTarMethod). It would be good
> to fix that. I'm not quite sure whether
>
> http://postgr.es/m/pm1bMV6zZh9_4tUgCjSVMLxDX4cnBqCDGTmdGlvBLHPNyXbN18x_k00eyjkCCJGEajWgya2tQLUDpvb2iIwlD22IcUIrIt9WnMtssNh-F9k=@pm.me
> is basically what we need or whether something else is required.
>
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-02-11 15:07:49 Re: Teach pg_receivewal to use lz4 compression
Previous Message Robert Haas 2022-02-11 15:01:07 Re: refactoring basebackup.c