| From: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: CREATE SUBSCRIPTION ... SERVER vs. pg_dump, etc. |
| Date: | 2026-08-05 10:08:29 |
| Message-ID: | CANhcyEWRTw6-eD94q2e=MuwUYDqpkmaVQsOK8ZE1L2t+NjoDFg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 4 Aug 2026 at 06:31, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> On Mon, 2026-08-03 at 16:06 +0530, Amit Kapila wrote:
> > Right, that is possible. In such a scenario, the current behavior of
> > the apply-worker appears okay to me. Anyway, the feature
> > disable_on_error is for the user to evaluate/analyze the current
> > ERROR
> > and accordingly take the next action. In this case, she can enable
> > the
> > subscription again.
>
> That makes sense to me.
>
> > > Or, perhaps these are just edge cases, and part (b) is not very
> > > important?
> > >
> >
> > I think so. We don't need to do anything for part (b).
>
> Agreed.
>
> > BTW, shall we add a detailed comment as to why we separate the load
> > of
> > connection info from other subscription parameters for future readers
> > on the following lines:
>
> Done using your wording in v4-0001.
>
> New v4 series attached.
>
Hi Jeff,
I have tested the patches and confirm that the issue reported by me in
[1] is addressed.
Also, I tested for the issue reported by Kuroda-san in [2]. And
confirm that it is also addressed.
[1]: https://www.postgresql.org/message-id/CANhcyEU9VsaLwo908ws_1MxNB79f%2Bcr-JVfig%3DZoaf4%2BKQe%2BGQ%40mail.gmail.com
[2]: https://www.postgresql.org/message-id/OS9PR01MB12149C3ED34272966B25DB173F5C12@OS9PR01MB12149.jpnprd01.prod.outlook.com
Thanks,
Shlok Kyal
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-08-05 10:12:35 | Re: Fix archive restore race that could unlink WAL before rename |
| Previous Message | Amit Langote | 2026-08-05 10:05:50 | Re: RI fast path gets cross-type foreign keys wrong |