| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: CREATE SUBSCRIPTION ... SERVER vs. pg_dump, etc. |
| Date: | 2026-08-04 01:00:57 |
| Message-ID: | d7d168cb94fb5543fd603a4deb79e4a253a5725a.camel@j-davis.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 2026-08-03 at 16:06 +0530, Amit Kapila wrote:
> Right, that is possible. In such a scenario, the current behavior of
> the apply-worker appears okay to me. Anyway, the feature
> disable_on_error is for the user to evaluate/analyze the current
> ERROR
> and accordingly take the next action. In this case, she can enable
> the
> subscription again.
That makes sense to me.
> > Or, perhaps these are just edge cases, and part (b) is not very
> > important?
> >
>
> I think so. We don't need to do anything for part (b).
Agreed.
> BTW, shall we add a detailed comment as to why we separate the load
> of
> connection info from other subscription parameters for future readers
> on the following lines:
Done using your wording in v4-0001.
New v4 series attached.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Remove-Subscription-conninfo-field-generate-in-ca.patch | text/x-patch | 16.5 KB |
| v4-0002-Build-subscription-conninfo-after-checking-that-i.patch | text/x-patch | 2.5 KB |
| v4-0003-Be-precise-about-when-ALTER-SUBSCRIPTION-needs-co.patch | text/x-patch | 6.4 KB |
| v4-0004-Always-check-foreign-server-USAGE-when-resolving-.patch | text/x-patch | 6.3 KB |
| v4-0005-For-subscription-DDL-demote-user-mapping-checks-t.patch | text/x-patch | 6.4 KB |
| v4-0006-CREATE-SUBSCRIPTION-do-not-construct-conninfo-unn.patch | text/x-patch | 5.2 KB |
| v4-0007-Revert-Validate-subscription-conninfo-on-owner-ch.patch | text/x-patch | 8.5 KB |
| v4-0008-When-changing-owner-of-a-subscription-do-not-thro.patch | text/x-patch | 4.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-08-04 01:31:36 | Re: [PATCH] Remove unused PartitionDescData.last_found_part_index field |
| Previous Message | Masahiko Sawada | 2026-08-04 00:41:52 | Re: Add a hook for handling logical decoding messages on subscribers. |