| From: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG? Unpublished generated columns are reported "missing" by the subscription |
| Date: | 2026-11-06 10:04:25 |
| Message-ID: | CANhcyEUam4pE4nGontFUpP16LC1rayy6juBTboSr1H8u=R7Jkw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 5 Nov 2026 at 16:09, Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> On Thu, Nov 5, 2026 at 10:47 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > On Wed, Nov 4, 2026 at 9:06 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> > ...
> > > To make the tests pass, I've included the v1 patch from [1], unchanged, as 0001.
> > >
> > > 0002 adds tests to 011_generated.pl for a table whose only column is
> > > VIRTUAL, and one whose only column is STORED with
> > > publish_generated_columns = none, in both text and binary mode.
> > >
> > > [1] https://www.postgresql.org/message-id/CAL5_ZS1bnYkK_GrA4N4SVKYgYsMMJxL9416m%3DvECAjrcwmQkkg%40mail.gmail.com
> > >
> >
> > Hi Ajin.
> >
> > Thanks for the 0002 patch!
> >
> > Basically, it LGTM, but here are a couple of very minor review comments.
> >
>
> Hi Peter,
>
> Thanks for your comments. Addressed. Also attached the new patch
> posted in [1] as patch 0001.
>
> [1] https://www.postgresql.org/message-id/CAL5_ZS1bnYkK_GrA4N4SVKYgYsMMJxL9416m%3DvECAjrcwmQkkg%40mail.gmail.com
>
Hi Ajin,
I have reviewed and tested the v2-0002 patch.
It looks good to me.
Thanks,
Shlok Kyal
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-11-06 10:04:52 | Re: [PATCH] Fix use-after-free after failed pg_checksum_init |
| Previous Message | Tender Wang | 2026-11-06 09:52:56 | EXPLAIN ANALYZE overcounts MERGE inserts suppressed by triggers |