| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG? Unpublished generated columns are reported "missing" by the subscription |
| Date: | 2026-11-05 10:38:25 |
| Message-ID: | CAFPTHDaSvJDLLTmrO=Z0rw50sQmaaVyurxzwas8Ho7w5NtpNcw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 5, 2026 at 10:47 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Wed, Nov 4, 2026 at 9:06 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> ...
> > To make the tests pass, I've included the v1 patch from [1], unchanged, as 0001.
> >
> > 0002 adds tests to 011_generated.pl for a table whose only column is
> > VIRTUAL, and one whose only column is STORED with
> > publish_generated_columns = none, in both text and binary mode.
> >
> > [1] https://www.postgresql.org/message-id/CAL5_ZS1bnYkK_GrA4N4SVKYgYsMMJxL9416m%3DvECAjrcwmQkkg%40mail.gmail.com
> >
>
> Hi Ajin.
>
> Thanks for the 0002 patch!
>
> Basically, it LGTM, but here are a couple of very minor review comments.
>
Hi Peter,
Thanks for your comments. Addressed. Also attached the new patch
posted in [1] as patch 0001.
regards,
Ajin Cherian
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-initial-sync-of-zero-column-published-tables.patch | application/octet-stream | 7.2 KB |
| v2-0002-Fix-tablesync-of-tables-with-no-published-columns.patch | application/octet-stream | 8.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ilia Evdokimov | 2026-11-05 10:38:26 | Re: Fold NOT IN / <> ALL expressions containing NULL to FALSE |
| Previous Message | vignesh C | 2026-11-05 10:07:47 | Re: [PATCH v1] Fix initial sync of zero-column published tables |