From: | Adrian Klaver <adrian(dot)klaver(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: note to reviewers: reply to the original email |
Date: | 2013-12-02 22:09:20 |
Message-ID: | CANf5jyOJ6N=YY5mGyaMzcSOSMY4Rxa405Ds7LGvRiB6xp9EVOw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Dec 2, 2013 at 1:30 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> A note to reviewers participating in the commit fests: When you send a
> review of a patch, reply to the email that contains the patch. Do no
> start a new email thread like "Review of 'Some Patch'". This is
> important for several reasons:
Might want to change the example
(http://www.postgresql.org/message-id/1247855889.6125.6.camel@lapdragon)
in:
https://wiki.postgresql.org/wiki/Reviewing_a_Patch
It shows the behavior you do not want :)
>
> - It maintains the integrity of the email archives. The commit fest app
> is supposed to track discussions, not be a participating link in the
> discussions.
>
> - It makes sure the right people get your review. If you start a new
> thread, worst case, no one participating in the original thread will see
> your email. This is especially true if the original thread and the
> commit fest entry have different titles, and you don't even CC the patch
> author on your review.
>
> If you don't have the original email in your email client, at least
> doctor up the subject line so it looks like a reply, so that email
> clients can do a reasonable job sorting the two threads together. Yes,
> email is stupid.
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
--
Adrian Klaver
adrian(dot)klaver(at)gmail(dot)com
From | Date | Subject | |
---|---|---|---|
Next Message | Brar Piening | 2013-12-02 22:12:28 | Visual Studio 2013 build |
Previous Message | Stephen Frost | 2013-12-02 21:56:56 | Re: Trust intermediate CA for client certificates |