Re: BUG #19450: Where is checksum_block.inc.c after master install?

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: rekgrpth(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #19450: Where is checksum_block.inc.c after master install?
Date: 2026-04-06 02:57:40
Message-ID: CANWCAZbbegtd55eA7DwkkSAHPHyh4x-ZR=JyuLr37ZOD56h_8A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> src/include/Makefile knows what it's supposed to install out
> of that subtree, and it thinks storage/*.h is sufficient.
> I didn't check to see if the meson system has the same oversight.
>
> One could argue that the real bug is having put a .c file into
> the include/ tree in the first place. Why was it done like that?
> Couldn't it be a .h file?

That was the way it was first coded. I thought of this way to avoid
adding an exception to headerscheck. I can reverse that decision
easily, but I may not get to it today.

--
John Naylor
Amazon Web Services

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2026-04-06 03:07:58 Re: BUG #19450: Where is checksum_block.inc.c after master install?
Previous Message Tom Lane 2026-04-06 02:50:54 Re: BUG #19450: Where is checksum_block.inc.c after master install?