| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <johncnaylorls(at)gmail(dot)com> |
| Cc: | rekgrpth(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #19450: Where is checksum_block.inc.c after master install? |
| Date: | 2026-04-06 03:07:58 |
| Message-ID: | 1199322.1775444878@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
John Naylor <johncnaylorls(at)gmail(dot)com> writes:
> On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> One could argue that the real bug is having put a .c file into
>> the include/ tree in the first place. Why was it done like that?
>> Couldn't it be a .h file?
> That was the way it was first coded. I thought of this way to avoid
> adding an exception to headerscheck. I can reverse that decision
> easily, but I may not get to it today.
Ah, the good ol' law of conservation of cruft. But on the whole
I think naming it .h not .c is less crufty. Agreed that there's
no great urgency about changing it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmytro Astapov | 2026-04-06 12:04:18 | Re: array_agg(anyarray) silently produces corrupt results with parallel workers when inputs mix NULL and non-NULL array elements |
| Previous Message | John Naylor | 2026-04-06 02:57:40 | Re: BUG #19450: Where is checksum_block.inc.c after master install? |