| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Batch TIDs lookup in ambulkdelete |
| Date: | 2025-06-09 11:03:33 |
| Message-ID: | CANWCAZbNAodK2F12J74H-5rLrDPguOvUO7_ZoP1U=-M1Bi8Mpg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jun 7, 2025 at 4:34 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> BTW I found that the constant 'maxblkno' in test_tidstore.sql actually
> equals to InvalidBlockNumber, but not MaxBlockNumber. I think it
> doesn't make sense that TidStore uses InvalidBlockNumber as the key.
> The attached 0001 patch fixes it. I think we can fix it separately on
> HEAD as well as back branches.
I don't see a bug here, so I don't see the need for a backpatch -- the
block numbers in the tests are just numbers, they don't refer to
actual relations. I understand the desire to make it closer to
reality, but it seems cosmetic.
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2025-06-09 11:15:51 | Re: Missing program_XXX calling in pgbench tests |
| Previous Message | Dilip Kumar | 2025-06-09 10:56:32 | Re: Add new wait event to XactLockTableWait |