Re: Add new wait event to XactLockTableWait

From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Xuneng Zhou <xunengzhou(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Kevin K Biju <kevinkbiju(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add new wait event to XactLockTableWait
Date: 2025-06-09 10:56:32
Message-ID: CAFiTN-uKByi-1-0x5M8Ut2TDR-2dJEMrNr7Ei5vNwzwnCToVjg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Jun 9, 2025 at 2:18 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
>
>
> On 2025/06/09 14:19, Xuneng Zhou wrote:
> > Hi,
> >
> > On Mon, Jun 9, 2025 at 12:52 PM Xuneng Zhou <xunengzhou(at)gmail(dot)com <mailto:xunengzhou(at)gmail(dot)com>> wrote:
> > >
> > > Hi,
> > >
> > > > Please find attached Version 2, incorporating the suggested changes.
> > >
> > > Apologies for the confusion — in the previous attempt, I mistakenly
> > > named the patch file with a `0002-` prefix, thinking it reflected the
> > > patch version rather than the patch series number. I've corrected the
> > > filename to follow the proper convention.
> >
> > Sorry for the missing hyphen in the patch name. Things should be in good shape now. I need to be more cautious and double-check everything before submitting patches and sending emails.😂
>
> Thanks for updating the patch! It looks good to me.
>
> I think we can mark it as "Ready for Committer" in the CommitFest.
> Unless there are any objections, I'll commit it once v19 development opens.

LGTM, except I suggest using WAIT_EVENT_XACT_COMPLETE instead of
WAIT_EVENT_XACT_DONE. I think it sounds better.

--
Regards,
Dilip Kumar
Google

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2025-06-09 11:03:33 Re: Batch TIDs lookup in ambulkdelete
Previous Message Ashutosh Bapat 2025-06-09 10:50:39 Re: Add enable_groupagg GUC parameter to control GroupAggregate usage