| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | rekgrpth(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #19450: Where is checksum_block.inc.c after master install? |
| Date: | 2026-04-07 08:56:51 |
| Message-ID: | CANWCAZb968EFqj1Q67yPNn2xVaWg6ASShz+kbJ5G-pP0s3BEEA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Apr 6, 2026 at 10:07 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> John Naylor <johncnaylorls(at)gmail(dot)com> writes:
> > On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> One could argue that the real bug is having put a .c file into
> >> the include/ tree in the first place. Why was it done like that?
> >> Couldn't it be a .h file?
>
> > That was the way it was first coded. I thought of this way to avoid
> > adding an exception to headerscheck. I can reverse that decision
> > easily, but I may not get to it today.
>
> Ah, the good ol' law of conservation of cruft. But on the whole
> I think naming it .h not .c is less crufty. Agreed that there's
> no great urgency about changing it.
Okay, done that way as of commit 8c3e22a8f.
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2026-04-07 15:18:49 | Re: BUG #19451: In postgreSQL v13 For 1000 tables how to update from rrn column to GUID. Each table more than 2crore |
| Previous Message | Chris Hofstaedtler | 2026-04-07 08:53:36 | Re: BUG #19416: Backend SIGSEGV in ExecShutdownHashJoin/ExecHashTableDetach/dsa_free |