| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gurjeet Singh <gurjeet(at)singh(dot)im>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Change GUC hashtable to use simplehash? |
| Date: | 2023-12-18 06:39:02 |
| Message-ID: | CANWCAZYqKBU3zfrXGXcYEuapvpB4E3DMgXABk6mCvaWW7x8P6w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Updated next steps:
> * Add some desperately needed explanatory comments.
There is a draft of this in v10-0001. I also removed the validation
scaffolding and ran pgindent. This could use some review and/or
bikeshedding, in particular on the name hashfn_unstable.h. I also
considered *_volatile.h or *_inmemory.h, but nothing stands out as
more clear.
> * Use this in some existing cases where it makes sense.
For now just two:
v10-0002 is Jeff's change to the search path cache, but with the
chunked interface that I found to be faster.
v10-0003 is a copy of something buried in an earlier version: use in
pgstat. Looks nicer, but not yet tested.
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0003-Use-fasthash32-for-pgstat_hash_hash_key.patch | text/x-patch | 1.6 KB |
| v10-0002-Use-fasthash-for-the-search-path-cache.patch | text/x-patch | 2.1 KB |
| v10-0001-Add-inlineable-incremental-hash-functions-for-in.patch | text/x-patch | 7.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2023-12-18 06:39:22 | Re: introduce dynamic shared memory registry |
| Previous Message | Bharath Rupireddy | 2023-12-18 05:58:46 | Re: Fix a comment in basic_archive about NO_INSTALLCHECK |