| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix a comment in basic_archive about NO_INSTALLCHECK |
| Date: | 2023-12-18 05:58:46 |
| Message-ID: | CALj2ACVR2tes=E=kWGvZerPm6Y4BHw9nQWCfLFx1cxPkPK-zhg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 6, 2023 at 9:26 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Apr 03, 2023 at 08:56:10AM +0530, Bharath Rupireddy wrote:
> > It looks like comments in make file and meson file about not running
> > basic_archive tests in NO_INSTALLCHECK mode are wrong. The comments say the
> > module needs to be loaded via shared_preload_libraries=basic_archive, but
> > it actually doesn't. The custom file needs archive related parameters and
> > wal_level=replica. Here's a patch correcting that comment.
>
> Saying that, updating the comments about the dependency with
> archive_library and the module's GUC is right.
Reworded the comment a bit and attached the v2 patch.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-a-comment-in-basic_archive-about-NO_INSTALLCH.patch | application/octet-stream | 1.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2023-12-18 06:39:02 | Re: Change GUC hashtable to use simplehash? |
| Previous Message | Andrey M. Borodin | 2023-12-18 05:49:23 | Re: Transaction timeout |