| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Adjust error message for CREATE STATISTICS to account for expressions |
| Date: | 2026-03-26 09:22:07 |
| Message-ID: | CANWCAZYjDSsvC6M6pas26ffbj-TZmXOHHC1-DwRM2LFa+qr3GQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 25, 2026 at 11:15 AM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
>
> On Wed, 25 Mar 2026 08:24:40 +0700
> John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
> > I'm ambivalent about this. Instead of trying to document all the
> > possible valid possibilities (which may get out of date again), maybe
> > we can say that it's not allowed on a single column?
>
> Thank you for the suggestion. I agree that this is a simpler approach,
> so I've attached a revised patch.
- errmsg("extended statistics require at least 2 columns")));
+ errmsg("extended statistics are not supported on a single column")));
I'd probably write this as "extended statistics on a single column are
not supported" (no need to send a new patch).
Any objections?
Also, I'm leaning towards not backpatching -- I figure a user that got
here by fat-fingering an expression is not likely to be too confused.
I looked in the feature thread and saw that this was actually raised
during development of the feature:
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2026-03-26 09:24:28 | Re: generic plans and "initial" pruning |
| Previous Message | jian he | 2026-03-26 08:59:56 | Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions |