Re: Adjust error message for CREATE STATISTICS to account for expressions

From: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adjust error message for CREATE STATISTICS to account for expressions
Date: 2026-03-26 10:03:29
Message-ID: 20260326190329.7a85cb47b158cf21e960c185@sraoss.co.jp
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

That sounds good to me.That sounds good to me.On Thu, 26 Mar 2026 16:22:07 +0700
John Naylor <johncnaylorls(at)gmail(dot)com> wrote:

> On Wed, Mar 25, 2026 at 11:15 AM Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> >
> > On Wed, 25 Mar 2026 08:24:40 +0700
> > John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
>
> > > I'm ambivalent about this. Instead of trying to document all the
> > > possible valid possibilities (which may get out of date again), maybe
> > > we can say that it's not allowed on a single column?
> >
> > Thank you for the suggestion. I agree that this is a simpler approach,
> > so I've attached a revised patch.
>
> - errmsg("extended statistics require at least 2 columns")));
> + errmsg("extended statistics are not supported on a single column")));
>
> I'd probably write this as "extended statistics on a single column are
> not supported" (no need to send a new patch).
>
> Any objections?

That sounds good to me.

> Also, I'm leaning towards not backpatching -- I figure a user that got
> here by fat-fingering an expression is not likely to be too confused.

+1

Regards,
Yugo Nagata

> I looked in the feature thread and saw that this was actually raised
> during development of the feature:
>
> https://www.postgresql.org/message-id/CAEZATCU9uPo7JYdx4k0-ufXXZH8t7itodibUwCva%2Bs%2BAvAKcnw%40mail.gmail.com
>
> --
> John Naylor
> Amazon Web Services

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2026-03-26 10:10:10 Re: Use SIGTERM instead of SIGUSR1 for slotsync worker to exit during promotion?
Previous Message Alexandre Felipe 2026-03-26 09:51:56 Re: SLOPE - Planner optimizations on monotonic expressions.