| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | albert tan <alterttan1223(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Correct comment wording in extension.c |
| Date: | 2026-01-07 06:55:53 |
| Message-ID: | CANWCAZYgLtgwKFvwe+sGaN-r8-65DxnQctREuk=VDLbfg=X4XA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 7, 2026 at 1:13 PM albert tan <alterttan1223(at)gmail(dot)com> wrote:
> I believe:
> 'will be searched' is better than 'will be search'.
> 'it assumes' is better than 'it assume'.
Those are indeed grammatical errors. From a quick eyeball scan, this
file has other wording issues:
/*
* Ignore already-found names. They are not reachable by the
* path search, so don't shown them.
*/
"show"
/*
* The directory parameter can be omitted, absolute, or relative to the
* installation's base directory, which can be the sharedir or a custom
* path that it was set extension_control_path. It depends where the
* .control file was found.
*/
I imagine this means "or a custom path that was set via extension_control_path".
/*
* Return a list of directories declared on extension_control_path GUC.
*/
I would guess this normally phrased something like "Return the list of
directories in extension_control_path".
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Lukas Fittl | 2026-01-07 07:04:19 | Re: pg_plan_advice |
| Previous Message | Henson Choi | 2026-01-07 06:45:53 | Re: SQL Property Graph Queries (SQL/PGQ) |