| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Eduard Stefes <eduard(dot)stefes(at)ibm(dot)com>, "iii(at)linux(dot)ibm(dot)com" <iii(at)linux(dot)ibm(dot)com>, "rueckner(at)linux(dot)ibm(dot)com" <rueckner(at)linux(dot)ibm(dot)com> |
| Subject: | Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X |
| Date: | 2025-05-07 22:32:37 |
| Message-ID: | CANWCAZYewJBQDFC9GB_aq5hvtpTU90+GTq+WKJY8CyjF1cfDAg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 7, 2025 at 8:15 PM Aleksander Alekseev
<aleksander(at)timescale(dot)com> wrote:
>
> I didn't review the patch but wanted to point out that when it comes
> to performance improvements it's typically useful to provide some
> benchmarks.
+1 -- It's good to have concrete numbers for the commit message, and
also to verify improvement on short inputs. There is a test harness in
the v7-0002 patch from here:
After building, run the "test-crc.sh" script here after executing
"CREATE EXTENSION test_crc32c;":
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-05-07 22:35:44 | Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X |
| Previous Message | John Naylor | 2025-05-07 22:23:52 | Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X |