Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Eduard Stefes <eduard(dot)stefes(at)ibm(dot)com>, "iii(at)linux(dot)ibm(dot)com" <iii(at)linux(dot)ibm(dot)com>, "rueckner(at)linux(dot)ibm(dot)com" <rueckner(at)linux(dot)ibm(dot)com>
Subject: Re: Review/Pull Request: Adding new CRC32C implementation for IBM S390X
Date: 2025-05-07 13:15:10
Message-ID: CAJ7c6TMian+pDWJeqZ584ix_ht_rR_PHxZfWgrriRtxjGw2Jrg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Eduard,

> Here I send a patch that adds a vectorized version of CRC32C for the
> IBM S390X hardware. I kindly ask for a review of the code and to pick
> it up in upstream postgresql.
> [...]
> Cheers and thanks to all for their work,

Thanks for submitting this patch.

Please register it on the nearest open commitfest [1] so that it
wouldn't be lost.

I didn't review the patch but wanted to point out that when it comes
to performance improvements it's typically useful to provide some
benchmarks.

[1]: https://commitfest.postgresql.org/53/

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2025-05-07 13:23:18 Re: Improve tab completion for COPY
Previous Message Nikhil Kumar Veldanda 2025-05-07 12:15:40 Re: ZStandard (with dictionaries) compression support for TOAST compression