| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: GB18030-2022 Support in PostgreSQL |
| Date: | 2025-09-16 09:36:02 |
| Message-ID: | CANWCAZYK=-cirU0ZW7AMGuFnOrzS1PA1ptmww5EUz7QukZf4Lw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 12, 2025 at 8:57 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> * In 0003, updated a function comment in utf8_and_gb18030.c to address John's comment about reference to the xml file.
Thanks, but the entire point of that comment change was to remove the
reference to the XML file, yet it didn't actually do that. Also, the
words in my email were to explain to you what should go there and why.
That doesn't mean those words belong in the comment.
The comment change seems like it belongs in the preparatory commit
anyway, so I put the links there and pushed 0001 (along with the
squashed 0002).
--
John Naylor
Amazon Web Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-09-16 09:51:19 | Re: Parallel Apply |
| Previous Message | Amit Kapila | 2025-09-16 09:33:18 | Re: Parallel Apply |