| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
| Cc: | "Seki, Eiji" <seki(dot)eiji(at)jp(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags |
| Date: | 2017-03-22 16:42:31 |
| Message-ID: | CANP8+jK5FrFjzhuAZCoyrtjKej3sM68ODQY9zSep++VDs-RELQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22 March 2017 at 03:42, Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> wrote:
>
>
> On Wed, Mar 22, 2017 at 1:53 PM, Seki, Eiji <seki(dot)eiji(at)jp(dot)fujitsu(dot)com>
> wrote:
>>
>>
>> Thank you for your review, again.
>>
>> I think your proposals are better, so I reflected them.
>
>
> Thanks for the updated patch. Patch looks good to me.
> I marked it as "ready for committer".
Looks good. I'll double check and commit this.
> While reviewing this patch, I found that PGXACT->vacuumFlags
> variable name needs a rename because with the addition of
> PROC_IN_LOGICAL_DECODING flag "vacuumFlags" doesn't
> only use it for vacuum operation. I feel this variable can be renamed
> as just "flags", but anyway that is a different patch.
Good point. Should be an open item.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-03-22 16:51:33 | Re: increasing the default WAL segment size |
| Previous Message | Robert Haas | 2017-03-22 16:39:13 | Re: increasing the default WAL segment size |