| From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
|---|---|
| To: | "Seki, Eiji" <seki(dot)eiji(at)jp(dot)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Proposal: GetOldestXminExtend for ignoring arbitrary vacuum flags |
| Date: | 2017-03-22 03:42:03 |
| Message-ID: | CAJrrPGcsDC-oy1AhqH0JkXYa0Z2AgbuXzHPpByLoBGMxfOZMEQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 22, 2017 at 1:53 PM, Seki, Eiji <seki(dot)eiji(at)jp(dot)fujitsu(dot)com>
wrote:
>
> Thank you for your review, again.
>
> I think your proposals are better, so I reflected them.
Thanks for the updated patch. Patch looks good to me.
I marked it as "ready for committer".
While reviewing this patch, I found that PGXACT->vacuumFlags
variable name needs a rename because with the addition of
PROC_IN_LOGICAL_DECODING flag "vacuumFlags" doesn't
only use it for vacuum operation. I feel this variable can be renamed
as just "flags", but anyway that is a different patch.
Regards,
Hari Babu
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-03-22 03:45:52 | Re: PUBLICATIONS and pg_dump |
| Previous Message | Craig Ringer | 2017-03-22 03:39:32 | Re: Allow pg_dumpall to work without pg_authid |