| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SHOW ALL does not honor pg_read_all_settings membership |
| Date: | 2018-05-31 18:05:58 |
| Message-ID: | CANP8+jLwcTWfX_OnA0uPetDZmOSjS_3gVVx-TnRGG=GhrWe2ig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17 April 2018 at 04:28, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Mon, Apr 16, 2018 at 02:32:10PM +0200, Laurenz Albe wrote:
>> Now that the dust from the last commitfest is settling, I'll make a second
>> attempt to attract attention for this small bug fix.
>>
>> The original commit was Simon's.
>
> Thanks for the ping.
>
> This was new as of v10, so this cannot be listed as an open item still I
> have added that under the section for older bugs, because you are right
> as far as I can see.
OK, agreed, its a bug.
Any objections to backpatch to v10?
> GetConfigOption is wrong by the way, as restrict_superuser means that
> all members of the group pg_read_all_settings can read
> GUC_SUPERUSER_ONLY params, and not only superusers, so the comment at
> least needs a fix, the variable ought to be renamed as well.
OK
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-05-31 18:42:42 | Re: SHOW ALL does not honor pg_read_all_settings membership |
| Previous Message | Simon Riggs | 2018-05-31 17:31:24 | Re: pg_replication_slot_advance to return NULL instead of 0/0 if slot not advanced |