| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, simon(at)2ndquadrant(dot)com |
| Subject: | Re: SHOW ALL does not honor pg_read_all_settings membership |
| Date: | 2018-04-17 03:28:58 |
| Message-ID: | 20180417032858.GD4998@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 16, 2018 at 02:32:10PM +0200, Laurenz Albe wrote:
> Now that the dust from the last commitfest is settling, I'll make a second
> attempt to attract attention for this small bug fix.
>
> The original commit was Simon's.
Thanks for the ping.
This was new as of v10, so this cannot be listed as an open item still I
have added that under the section for older bugs, because you are right
as far as I can see.
GetConfigOption is wrong by the way, as restrict_superuser means that
all members of the group pg_read_all_settings can read
GUC_SUPERUSER_ONLY params, and not only superusers, so the comment at
least needs a fix, the variable ought to be renamed as well.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2018-04-17 06:01:33 | pg_recvlogical broken in back branches |
| Previous Message | Michael Paquier | 2018-04-17 03:17:28 | Re: Fix slot's xmin advancement and subxact's lost snapshots in decoding. |