Re: Remove unused function from walsender.c

From: Simon Riggs <simon(at)2ndQuadrant(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove unused function from walsender.c
Date: 2016-04-11 21:36:24
Message-ID: CANP8+jLo1CRx=ChqumEPQuNUOSjo-inQdh-hQUFekEY4=M_YCA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11 April 2016 at 08:05, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:

> There is an unused function GetOldestWALSendPointer() in walsender.c.
> Per comment, it was introduced because we may need it in the future for
> synchronous replication.
>
> Now we have very similar function SyncRepGetOldestSyncRecPtr() in
> syncrep.c. Which makes me think that GetOldestWALSendPointer()
> no longer needs to be maintained. So, is it time to remove that unused
> function?
>

Seems sensible cleanup to me.

--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-04-11 21:40:29 Re: Move PinBuffer and UnpinBuffer to atomics
Previous Message Simon Riggs 2016-04-11 21:35:28 Re: Removing the TRACE_SORT macro