Re: Proposal for changes to recovery.conf API

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal for changes to recovery.conf API
Date: 2016-11-29 15:13:57
Message-ID: CANP8+jLa2W2o3+5hh=jJtSax23x+gL5_aTjja9Pc1pUB1o_ciw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 14 November 2016 at 15:50, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sat, Nov 12, 2016 at 11:09 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> I'm very tempted to rename this during the move to GUCs
> ...
>> Slightly less so, but still tempted to also rename these. They're not
>> actually necessarily pointing towards a primary, and namespace-wise
>> they're not grouped with recovery_*, which has become more important now
>> that recovery.conf isn't a separate namespace anymore.
>
> -1 for renaming these. I don't think the current names are
> particularly bad, and I think trying to agree on what would be better
> could easily sink the whole patch.

OK, so we can move forward. Thanks.

I'm going to be doing final review and commit this week, at the
Developer meeting on Thurs and on Friday, with input in person and on
list.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2016-11-29 15:21:02 Compiler warnings
Previous Message Daniel Verite 2016-11-29 15:02:45 Re: pg_dump / copy bugs with "big lines" ?