Re: pg_basebackup wish list

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_basebackup wish list
Date: 2016-09-01 09:05:13
Message-ID: CANP8+jLAtehRaE5nvpWRCB5vS6993oH6JDfwAz6uvd0gG+ipoA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19 August 2016 at 08:46, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> On Fri, Aug 19, 2016 at 2:04 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> I agree with adding this as an option and removing directory by default.
>> And it looks good to me except for missing new line in usage output.
>>
>> printf(_(" -l, --label=LABEL set backup label\n"));
>> + printf(_(" -n, --noclean do not clean up after errors"));
>> printf(_(" -P, --progress show progress information\n"));
>>
>> Registered this patch to CF1.
>
> +1 for the idea. Looking at the patch it is taking a sane approach.

Apart from this one liner change we look good to go.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavan Deolasee 2016-09-01 09:07:40 Re: Patch: Write Amplification Reduction Method (WARM)
Previous Message Robert Haas 2016-09-01 09:02:55 Re: Add support for restrictive RLS policies