| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_basebackup wish list |
| Date: | 2016-08-19 07:46:29 |
| Message-ID: | CAB7nPqR=2P5QXHYQquuNj9WzXbOpL6z0DAtFiaaoUV=idbAdgQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 19, 2016 at 2:04 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> I agree with adding this as an option and removing directory by default.
> And it looks good to me except for missing new line in usage output.
>
> printf(_(" -l, --label=LABEL set backup label\n"));
> + printf(_(" -n, --noclean do not clean up after errors"));
> printf(_(" -P, --progress show progress information\n"));
>
> Registered this patch to CF1.
+1 for the idea. Looking at the patch it is taking a sane approach.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-08-19 08:58:52 | patch: function xmltable |
| Previous Message | konstantin knizhnik | 2016-08-19 07:34:33 | Logical decoding restart problems |