Re: let's not complain about harmless patch-apply failures

On 16 January 2018 at 16:56, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Jan 16, 2018 at 4:04 AM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> At Mon, 15 Jan 2018 21:45:34 -0500, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote in <26718(dot)1516070734(at)sss(dot)pgh(dot)pa(dot)us>
>>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> > Since the "Stripping trailing CRs from patch" message is totally
>>> > harmless, I'm not sure why you should need to devote any effort to
>>> > avoiding it. Anyone who gets it should just ignore it.
>>
>> I know that and totally agree to Robert but still I wonder why
>> (and am annoyed by) I sometimes receive such complain or even an
>> accusation that I sent an out-of-the-convention patch and I was
>> afraid that it is not actually common.
>
> I've seen that before as well.
>
> I have also noticed people complaining

People complain... asking them not to is unlikely to get anywhere.

We must encourage people to speak up if they see an improvement or a
lack of quality. I have benefited from such comments and they are not
often intended negatively.

Every complaint is not a hard blocker and complainers can also be
wrong, so we just need perspective.

--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services