| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Sergei Kornilov <sk(at)zsrv(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: let's not complain about harmless patch-apply failures |
| Date: | 2018-01-16 17:22:35 |
| Message-ID: | CA+TgmoYF2sDP=WPdvYB9jDGHSib7+CA_VmeYOR6NmD9M0Km6FQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 16, 2018 at 12:10 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> People complain... asking them not to is unlikely to get anywhere.
It doesn't hurt to ask.
> We must encourage people to speak up if they see an improvement or a
> lack of quality. I have benefited from such comments and they are not
> often intended negatively.
>
> Every complaint is not a hard blocker and complainers can also be
> wrong, so we just need perspective.
I'm not disagreeing with any of that. However, sending a patch with
CRLF line endings, or one that applies with minor offsets, is not a
lack of quality. Complaining about it serves no purpose.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-01-16 17:31:18 | Re: proposal: alternative psql commands quit and exit |
| Previous Message | Robert Haas | 2018-01-16 17:20:31 | Re: proposal: alternative psql commands quit and exit |