| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
| Subject: | Re: Needless additional partition check in INSERT? |
| Date: | 2018-05-10 05:42:03 |
| Message-ID: | CANP8+j+iM9pBLvd-O8hBodqmjAQjYg-+cR0QwATYqods9-u1Ww@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10 May 2018 at 05:33, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> wrote:
> On 10 May 2018 at 16:13, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> The patch to ExecInsert looks good, but I think we also need to do the
>> same thing in CopyFrom.
>
> I think so too.
>
> Updated patch attached.
Patch is good.
The cause of this oversight is the lack of comments to explain the
original coding, so we need to correct that in this patch, please.
--
Simon Riggs http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hubert Zhang | 2018-05-10 06:32:59 | Considering signal handling in plpython again |
| Previous Message | Pavan Deolasee | 2018-05-10 05:22:12 | PANIC during crash recovery of a recently promoted standby |