| From: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> |
|---|---|
| To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> |
| Subject: | Re: Needless additional partition check in INSERT? |
| Date: | 2018-05-10 09:56:09 |
| Message-ID: | CAKJS1f9X4g+SgEyZw+tL2ESen9hU=qansFnaPTBwMeeb1zH-ZA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10 May 2018 at 17:42, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> Patch is good.
>
> The cause of this oversight is the lack of comments to explain the
> original coding, so we need to correct that in this patch, please.
Thanks for looking.
Yeah, the comments do need work. In order to make it a bit easier to
document I changed the way that check_partition_constr is set. This is
now done with an if/else if/else clause for both COPY and INSERT.
Hopefully, that's easier to understand and prevents further mistakes.
Patch attached.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| remove_needless_additional_partition_check_v3.patch | application/octet-stream | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2018-05-10 10:33:53 | Re: doc fixes: vacuum_cleanup_index_scale_factor |
| Previous Message | Marina Polyakova | 2018-05-10 09:36:22 | Re: [HACKERS] path toward faster partition pruning |