| From: | Keisuke Kuroda <keisuke(dot)kuroda(dot)3862(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, tatsuhito(dot)kasahara(dot)rd(at)hco(dot)ntt(dot)co(dot)jp |
| Subject: | Re: Huge memory consumption on partitioned table with FKs |
| Date: | 2020-12-04 03:00:09 |
| Message-ID: | CANDwggJcdu3Cbtr50X+zLXoh+rB-MYfp=GGqbfv8TVS3VT4tuA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Amit,
> I have attached a patch in which I've tried to merge the ideas from
> both my patch and Kuroda-san's. I liked that his patch added
> conparentid to RI_ConstraintInfo because that saves a needless
> syscache lookup for constraints that don't have a parent. I've kept
> my idea to compute the root constraint id only once in
> ri_LoadConstraint(), not on every invocation of ri_BuildQueryKey().
> Kuroda-san, anything you'd like to add to that?
Thank you for the merge! It looks good to me.
I think a fix for InvalidateConstraintCacheCallBack() is also good.
I also confirmed that the patch passed the make check-world.
Best Regards,
--
Keisuke Kuroda
NTT Software Innovation Center
keisuke(dot)kuroda(dot)3862(at)gmail(dot)com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2020-12-04 03:00:17 | Re: [bug fix] ALTER TABLE SET LOGGED/UNLOGGED on a partitioned table does nothing silently |
| Previous Message | Amit Kapila | 2020-12-04 02:52:33 | Re: Single transaction in the tablesync worker? |