| From: | Salma El-Sayed <salmasayed182003(at)gmail(dot)com> |
|---|---|
| To: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Kirk Wolak <wolakk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: PoC: Simplify recovery after dropping a table by LOGGING the restore LSN |
| Date: | 2026-10-12 12:14:36 |
| Message-ID: | CANBEAPENH3o0YHQQn3RAmoDQsX0N_gnsTWfCSsaGjJ_bW3ntpA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Jim,
On Sun, Oct 11, 2026 at 1:27 AM Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> wrote:
> v6 no longer applies to master, since two new tests were added. 0001 is
> v6 rebased, with the test file renamed to
> 060_drop_table_logging.pl and meson.build updated accordingly -- no
> other changes.
Thanks for your response and for fixing the rebase conflict.
>
> == drop database ==
>
> But I was wondering if capturing the lsn right after
> pgstat_drop_database(db_id) woul be a better option here.I tested that
> locally, and recovering to that lsn gives back a valid database, with
> its original CONNECTION LIMIT, settings and data, and no manual step
> needed -- That's in 0002. It still needs more testing..
>
I agree that avoiding the manual step is much better. I tested your
patch and it works as expected. I included your fix in the main patch
and updated the documentation accordingly.
I also had an LLM help write more tests (for drop db recovery and truncate).
Attached is v8 rebased on master.
Best regards,
Salma Elsayed
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-Add-LSN-logging-for-DROP-TRUNCATE-TABLE-and-DROP-.patch | text/x-patch | 51.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2026-10-12 12:17:29 | Re: Parallel Apply |
| Previous Message | Nazir Bilal Yavuz | 2026-10-12 12:04:04 | Re: PANIC serves too many masters |