Re: PoC: Simplify recovery after dropping a table by LOGGING the restore LSN

Hi Salma

On 28/09/2026 15:54, Salma El-Sayed wrote:
> Attached is v6 of the patch to log the target LSN on DROP TABLE,
> TRUNCATE TABLE, and DROP DATABASE when the GUC log_object_drops is
> enabled (default off). This is based on Dmitry Lebedev's earlier work,
> which I have revised and extended.

Thanks for the patch!

v6 no longer applies to master, since two new tests were added. 0001 is
v6 rebased, with the test file renamed to
060_drop_table_logging.pl and meson.build updated accordingly -- no
other changes.

== drop database ==

IIUC simply adding a lsn recorded after a drop database expectedly
restores an invalid database, which I can confirm:

psql: error: connection to server on socket "/tmp/.s.PGSQL.5433" failed:
FATAL: cannot connect to invalid database "db"
HINT: Use DROP DATABASE to drop invalid databases.

But I was wondering if capturing the lsn right after
pgstat_drop_database(db_id) woul be a better option here.I tested that
locally, and recovering to that lsn gives back a valid database, with
its original CONNECTION LIMIT, settings and data, and no manual step
needed -- That's in 0002. It still needs more testing..

WDYT?

Thanks for working on this.

Best, Jim