Re: Making type Datum be 8 bytes everywhere

Hi,

Thank you for working on this!

On Wed, 23 Jul 2025 at 22:00, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I'm disinclined to put in a huge amount of effort looking for the
> worst case. We established long ago that we weren't going to
> optimize for 32-bit anymore. So as long as this doesn't completely
> tank performance on 32-bit, I'm satisfied. I'd almost say that
> if standard pgbench doesn't notice the change, that's good enough.

I did a basic pgbench benchmark on a 32-bit build and there is no change.

$ pgbench -i -s 100 test
$ pgbench -c 16 -j 16 -b $type -T 150 test

TPS results are:

select-only:
master: 215654
patched: 215751

simple-update:
master: 4454
patched: 4446

tpcb-like:
master: 4094
patched: 4128

--
Regards,
Nazir Bilal Yavuz
Microsoft