Re: split func.sgml to separated individual sgml files

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: split func.sgml to separated individual sgml files
Date: 2025-10-03 11:48:28
Message-ID: CAN55FZ1vrMRRFRX+GUg=VgRuLxXKAta4cmU9TdOTG9azVrhDfg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, 2 Oct 2025 at 23:16, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> > I suspect what you're really after here is the functionality of the
> > check-tabs and check-nbsp targets. So the new Perl script really just
> > has to cover those two and doesn't have to bother with xmllint. And
> > then you just call that script as part of the postgres-full.xml target.
>
> Yeah, that's what I was imagining: replace the xmllint call in
> postgres-full.xml with this new script that will also run the
> tab/nbsp checks.

Does not this mean we can not run the syntax check by itself in the
make builds? If I understand correctly, we need to create
postgres-full.xml each time we want to run the syntax check, right?

I was under the impression that the sgml_syntax_check.pl test would be
a lightweight way to do a syntax check, so that we could easily use it
by itself or in the CI.

--
Regards,
Nazir Bilal Yavuz
Microsoft

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2025-10-03 11:49:42 Re: Add memory_limit_hits to pg_stat_replication_slots
Previous Message Nazir Bilal Yavuz 2025-10-03 11:28:23 Re: split func.sgml to separated individual sgml files