| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, jian he <jian(dot)universality(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: split func.sgml to separated individual sgml files |
| Date: | 2025-10-03 11:28:23 |
| Message-ID: | CAN55FZ1VSrhEWJcEyr_00MPW9BrkcztG+QmrU1-utwODzKJJ2g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, 2 Oct 2025 at 21:43, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> On 2025-10-02 Th 8:52 AM, Nazir Bilal Yavuz wrote:
>
> I think there is one more problem that we need to think about. This
> test runs when the xmllint is enabled but it also requires docbook
> (docbook-xml on some OSes) to be installed, otherwise the test fails
> with 'I/O error : Attempt to load network entity
> http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd'. I think that
> we need to skip this test if the docbook can not be found in the
> system. Otherwise that would be a hassle for most of the people and
> buildfarm members. What do you think about this?
>
>
> Oops, missed seeing this earlier. Yes, I think we need to skip the test in the meson case. Probably nothing more needed for the Makefile.
Here is the patch which does that. It has a basic check for the
docbook and if the docbook can not be found, then meson skips the
test.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-meson-Skip-sgml_syntax_check-test-if-DocBook-DTD-.patch | text/x-patch | 2.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2025-10-03 11:48:28 | Re: split func.sgml to separated individual sgml files |
| Previous Message | Hayato Kuroda (Fujitsu) | 2025-10-03 11:14:44 | RE: Newly created replication slot may be invalidated by checkpoint |