Re: Stabilize and shorten test_checksums/013_rewind test

From: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
Subject: Re: Stabilize and shorten test_checksums/013_rewind test
Date: 2026-09-21 11:38:21
Message-ID: CAN55FZ0-BVx_B_3aROcA49Sh3ChfD_70RnQLrmoibXak1DZi0g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Mon, 21 Sept 2026 at 14:05, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 18 Sep 2026, at 15:47, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
>
> > My idea was that since the WAL needed by the tests has already been
> > flushed, I thought that would be enough for the tests. Also, is using
> > ->lsn('write') considered better for these cases or do you recommend
> > it because of the simplicity?
>
> I prefer when tests have the least amount of special needs setup outside of the
> code under test. This isn't really making assumptions which make the test
> synthetic though.

That makes sense.

> Another option for going with your patch is to use wait_for_replay_catchup
> which should accomplish the same.

Nice, I updated them with wait_for_replay_catchup().

--
Regards,
Nazir Bilal Yavuz
Microsoft

Attachment Content-Type Size
v2-0002-Fix-WAL-file-selection-in-checksum-rewind-test.patch application/octet-stream 1.9 KB
v2-0001-Avoid-idle-WAL-waits-in-the-checksum-rewind-test.patch application/octet-stream 2.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2026-09-21 11:51:49 Re: Write skew observed under serializable isolation
Previous Message solai v 2026-09-21 11:23:44 Re: [Patch] New pg_stat_tablespace view