Re: [PATCH] Use ssup_datum_*_cmp for int2, oid, and oid8 sort support

From: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
To: John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Use ssup_datum_*_cmp for int2, oid, and oid8 sort support
Date: 2026-07-24 12:04:33
Message-ID: CAN4CZFOyz02rKFgesJmwXv1YG2bZPPYuiqiKod=0=r8q_gmXXg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

LGTM.

+ * We cannot use ssup_datum_unsigned_cmp here, since we cannot count on
+ * Datums being zero-extended.

One nitpick that this explains the why, but it doesn't mention the
difference with oid8.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2026-07-24 12:38:35 Re: sequencesync worker race with REFRESH SEQUENCES
Previous Message Zhijie Hou (Fujitsu) 2026-07-24 12:03:18 RE: Collect ALTER PUBLICATION commands for event triggers