| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Use ssup_datum_*_cmp for int2, oid, and oid8 sort support |
| Date: | 2026-07-23 20:26:04 |
| Message-ID: | CANWCAZY9oHqpFxsZ=KT4SbP-pHB1QsbuxkUUBNBmSJDNYmEJog@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 23, 2026 at 3:15 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> > I think the easiest fix is to revert the oid part of commit 51cd5d6f0,
> > leaving behind the int2 and oid8 parts. The asymmetry between the 2
> > oid types would look odd, though, so that would require an explanatory
> > comment.
>
> Yes, that was my conclusion too, but I wanted to leave the decision up
> to you and Baji Shaik.
The attached is what I had in mind (including a regression test to
keep from tempting anyone else), with maybe some minor adjustments in
the comments.
--
John Naylor
Amazon Web Services
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Revert-using-ssup_datum_unsigned_cmp-for-comparin.patch | text/x-patch | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ilia Evdokimov | 2026-07-23 20:39:44 | Re: Remove redundant DISTINCT when GROUP BY already guarantees uniqueness |
| Previous Message | Nathan Bossart | 2026-07-23 19:56:16 | Re: convert various variables to atomics |