Re: pg_dump --exclude-table loses FOR ALL TABLES EXCEPT publications

> "When -t is specified, pg_dump makes no attempt to dump any other
> database objects that the selected table(s) might depend upon.

That note is actually my problem: because it documents the opposite
case: it says that when we exclude some tables, we do not dump any
other database object depending on it. That the quoted limitation is
for -e, -n, -t, while the issue I reported is about -N, -T and
--exclude-table-and-children.

And also note the inconsistency: with -e, -n and -t, we do what is
documented, resulting in a consistent restore that produces no errors
and no publications.
With the other options, it is the opposite: we dump publications that
depend on excluded database objects. Consequently, the restore ends
without the publication and prints errors.

So while I am also leaning towards simply documenting this, as I think
the current behavior is better than the alternative, we are
documenting an inconsistency. (And that's also the reason why I think
it is important to document this)

The comment for selectDumpablePublicationObject is also similarly incorrect:

A publication can have schemas and tables which have schemas, but those are
ignored in decision making, because publications are only dumped when we are
dumping everything.

When we exclude some tables, we clearly do not dump everything, but we
still dump publications.

As I wrote earlier, I think that keeping the current behavior is
correct: there's a reasonable chance that the user restores the
missing excluded table before the main dump, in which case we want to
have these publications there for completeness, excluding them would
be the wrong choice.

> OTOH, if others think that will be
> helpful, I won't mind adding it.

So I think expanding the note about this, and adjusting the code
comment would be an improvement, see attached patch. But if everyone
else disagrees, I am also fine with leaving it as-is.