| From: | Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, aleksander(at)timescale(dot)com |
| Subject: | Rename PqMsg_Progress to PqMsg_ParallelWorkerProgress |
| Date: | 2026-09-09 21:57:02 |
| Message-ID: | CAN12+YLqbiA1v3FPD94yLbXgdyoWxVEY6=DtdpTPo9YCRuCpfg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
While looking at this, I realized that "PqMsg_Progress" is the name of the
'P' message that was added for parallel index progress reporting.
I missed [1] at the time, but if there is still a chance to rename it to
"PqMsg_ParallelWorkerProgress", that seems better,
"PqMsg_Progress" does not really describe what it is, whereas
"PqMsg_ParallelWorkerProgress" makes it explicit that this is a
parallel-worker-to-leader message. It also matches other places in the code
that deal with parallel workers, such as "IsParallelWorker", so it is easier
to find when looking through parallel-worker code.
[1] https://www.postgresql.org/message-id/ZpboPlg1v38vJhsD%40nathan
--
Sami Imseih
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Cramer | 2026-09-09 22:04:11 | Re: Proposal to allow setting cursor options on Portals |
| Previous Message | Daniel Gustafsson | 2026-09-09 21:45:15 | Re: Offline data checksum changes can cause incorrect checksum state on standbys |