Re: Offline data checksum changes can cause incorrect checksum state on standbys

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Offline data checksum changes can cause incorrect checksum state on standbys
Date: 2026-09-09 21:45:15
Message-ID: 166AD46C-25A4-4AF3-B65F-095E3746A96E@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 7 Sep 2026, at 13:08, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:

> Let's add a new 'sect2' for this explanation, and move it after the "Online Enabling of Checksums" section. It's currently placed under "Offline Enabling of Checksums", but it actually goes into a lot of details of how *online* checksumming works, but "Online Enabling of Checksums" is covered in the following paragraph. If you read this in order like a novel, it feels weird.
>
> I think these paragraphs could use some copy-editing too. It feels like a pretty deep technical explanation, not very accessible to a DBA. Maybe start with "The primary server and replica can have different checksum states".
>
> (Not new with this patch, but: )
>
> The placement of the states in the state diagram on that page looks bizarre. I know it's auto-generated so not sure there's much we can do about it.. but could we, please? Maybe it'd get more clear if you leave 'initdb' out of the diagram. Or consider some completely different representation.

The attached v14 rewords and reorganizes the docs, and attempts to tidy uo the
state diagram. There are no new code changes in this version.

--
Daniel Gustafsson

Attachment Content-Type Size
v14-0005-doc-Documentation-updates-for-online-checksums.patch application/octet-stream 16.6 KB
v14-0004-pg_combinebackup-Refuse-mixed-data-checksum-stat.patch application/octet-stream 10.0 KB
v14-0003-pg_rewind-Check-the-data-checksum-states-of-sour.patch application/octet-stream 22.5 KB
v14-0002-pg_checksums-Refuse-interrupted-transitions-note.patch application/octet-stream 7.9 KB
v14-0001-Do-not-adopt-data-checksum-state-from-another-no.patch application/octet-stream 137.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sami Imseih 2026-09-09 21:57:02 Rename PqMsg_Progress to PqMsg_ParallelWorkerProgress
Previous Message Sami Imseih 2026-09-09 21:38:27 Re: Race conditions during parallel worker (unclean) exit