Re: Rename PqMsg_Progress to PqMsg_ParallelWorkerProgress

From: Kirill Reshke <reshkekirill(at)gmail(dot)com>
To: Sami Imseih <samimseih(dot)pg(at)gmail(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, aleksander(at)timescale(dot)com
Subject: Re: Rename PqMsg_Progress to PqMsg_ParallelWorkerProgress
Date: 2026-09-10 04:39:04
Message-ID: CALdSSPgFRV=43TJu0H_M0-divs11bO6Lgk3hRVHwqG4-Um6Aqw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 10 Sept 2026 at 02:57, Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> wrote:
>
> While looking at this, I realized that "PqMsg_Progress" is the name of the
> 'P' message that was added for parallel index progress reporting.
>
> I missed [1] at the time, but if there is still a chance to rename it to
> "PqMsg_ParallelWorkerProgress", that seems better,
> "PqMsg_Progress" does not really describe what it is, whereas
> "PqMsg_ParallelWorkerProgress" makes it explicit that this is a
> parallel-worker-to-leader message. It also matches other places in the code
> that deal with parallel workers, such as "IsParallelWorker", so it is easier
> to find when looking through parallel-worker code.
>
> [1] https://www.postgresql.org/message-id/ZpboPlg1v38vJhsD%40nathan
>
> --
> Sami Imseih
> Amazon Web Services (AWS)
>

Well, that's kind of bikeshedding for me to start with. But if we do,
maybe a better option will be to describe what this exactly does, not
who sends it. Like PgMsg_StatProgressReport or something. Does it
sound?

--
Best regards,
Kirill Reshke

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Michael Paquier 2026-09-10 04:25:06 Re: pgstat: Flush some statistics within running transactions, take 2