Re: Proposal for Signal Detection Refactoring

From: Chris Travers <chris(dot)travers(at)adjust(dot)com>
To: michael(at)paquier(dot)xyz
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Proposal for Signal Detection Refactoring
Date: 2018-09-26 07:50:00
Message-ID: CAN-RpxBQX834juPjwmsKha9RwESU5Br8XSrcdXv326-VYF00=g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 26, 2018 at 12:41 AM Michael Paquier <michael(at)paquier(dot)xyz>
wrote:

> On Mon, Sep 24, 2018 at 09:27:35PM -0700, Andres Freund wrote:
> > On 2018-09-25 11:50:47 +0900, Michael Paquier wrote:
> >> PGDLLIMPORT changes don't get back-patched as well...
> >
> > We've been more aggressive with that lately, and I think that's good. It
> > just is a unnecessarily portability barrier for extension to be
> > judicious in applying that.
>
> Agreed. Are there any objections with the proposal of changing the
> interruption pending flags in miscadmin.h to use sig_atomic_t?
> ClientConnectionLost would gain PGDLLIMPORT at the same time.
>

I am strongly in favor of doing this.

> --
> Michael
>

--
Best Regards,
Chris Travers
Head of Database

Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com
Saarbrücker Straße 37a, 10405 Berlin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Travers 2018-09-26 07:54:36 Re: Proposal for Signal Detection Refactoring
Previous Message Tahir Ramzan 2018-09-26 07:31:20 Re: Participate in GCI as a Mentor