Re: pg_rewind and postgresql.conf

From: Chris Travers <chris(dot)travers(at)adjust(dot)com>
To: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_rewind and postgresql.conf
Date: 2018-05-04 12:05:25
Message-ID: CAN-RpxB6vJ5d1bTj=gP4=6ccC3vVevCAtmLb5RQtOS1OMbGqWg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 4, 2018 at 12:59 PM, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:

> Currently pg_rewind copies all files including postgresql.conf. It
> would be nice if pg_rewind has an option to not copy
> postgresql.conf. I sometimes create multiple PostgreSQL database
> clusters with different port number which postmaster is listening on
> for a testing purpose. So existing postgresql.conf on the target
> cluster being overwritten by pg_rewind is annoying. I believe there
> are some use cases where different port numbers are used among
> PostgreSQL database clusters in the real world.
>
> Comments?
>

I totally agree. Ideally, rewind would just rewind data dirs by default
and provide an option to include other files as specified by the
administrator.

However I ran out of time this time to do this patch and hope to submit
again after 11 is finalized.

There are two other things that would really be nice to make work too (but
think that's another major version away):

1. Make pg_rewind work over the replication protocol so it doesn't require
db superuser
2. Unify, to the extent possible, the code base with pg_basebackup.

> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
>

--
Best Regards,
Chris Travers
Database Administrator

Tel: +49 162 9037 210 | Skype: einhverfr | www.adjust.com
Saarbrücker Straße 37a, 10405 Berlin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Isaac Morland 2018-05-04 12:06:47 Re: pg_rewind and postgresql.conf
Previous Message Robert Haas 2018-05-04 11:58:53 Re: make installcheck-world in a clean environment