Re: Pluggable toaster

From: Nikita Malakhov <hukutoc(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Greg Stark <stark(at)mit(dot)edu>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Pluggable toaster
Date: 2022-04-04 16:12:59
Message-ID: CAN-LCVN8WMk0zbJrqpq3wQFPvunMjsdCj4y5gyEuyH0+4Ax-DA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I'm really sorry. Messed up some code while merging rebased branches with
previous (v1)
patches issued in December and haven't noticed that seg fault because of
corrupted code
while running check-world.
I've fixed messed code in Dummy Toaster package and checked twice - all's
correct now,
patches are applied correctly and tests are clean.
Thank you for pointing out the error and for your patience!

On Sun, Apr 3, 2022 at 5:06 AM Andres Freund <andres(at)anarazel(dot)de> wrote:

> Hi,
>
> On April 2, 2022 6:20:36 PM PDT, Greg Stark <stark(at)mit(dot)edu> wrote:
> >Hm. It compiles but it's failing regression tests:
> >
> >diff -U3
> /tmp/cirrus-ci-build/contrib/dummy_toaster/expected/dummy_toaster.out
> >/tmp/cirrus-ci-build/contrib/dummy_toaster/results/dummy_toaster.out
> >--- /tmp/cirrus-ci-build/contrib/dummy_toaster/expected/dummy_toaster.out
> >2022-04-02 16:02:47.874360253 +0000
> >+++ /tmp/cirrus-ci-build/contrib/dummy_toaster/results/dummy_toaster.out
> >2022-04-02 16:07:20.878047769 +0000
> >@@ -20,186 +20,7 @@
> >....
> >+server closed the connection unexpectedly
> >+ This probably means the server terminated abnormally
> >+ before or while processing the request.
> >+connection to server was lost
> >I think this will require some real debugging, so I'm marking this
> >Waiting on Author.
>
> Yes, dumps core (just like in several previous runs):
>
> https://cirrus-ci.com/task/4710272324599808?logs=cores#L44
>
> Andres
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>

--
Regards,
Nikita Malakhov
Postgres Professional
https://postgrespro.ru/

Attachment Content-Type Size
3_toaster_snapshot_v4.patch.gz application/x-gzip 7.7 KB
4_bytea_appendable_toaster_v4.patch.gz application/x-gzip 19.5 KB
2_toaster_default_v4.patch.gz application/x-gzip 27.4 KB
1_toaster_interface_v4.patch.gz application/x-gzip 70.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2022-04-04 16:16:39 Re: New Object Access Type hooks
Previous Message Greg Stark 2022-04-04 15:54:23 Re: JSON constructors and window functions